Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the PEtab model by integrating SBML‐based default value determination into the parameter table. Key changes include initializing and passing the SBML viewer model, updating default value retrieval functions to accept an additional changes parameter, and propagating these updates across related controllers and commands.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/petab_gui/models/petab_model.py | Instantiates the SBML viewer and passes it to the ParameterModel |
| src/petab_gui/models/pandas_table_model.py | Updates default value logic to accept a “changed” dict and reorders columns |
| src/petab_gui/controllers/* | Propagates SBML default value updates and connection adjustments |
| src/petab_gui/commands.py | Adjusts new row initialization to use np.nan instead of empty strings |
| src/petab_gui/C.py | Introduces the SBML_LOOK strategy for nominal value defaults |
Comments suppressed due to low confidence (1)
src/petab_gui/commands.py:102
- [nitpick] Replacing empty strings with np.nan when inserting new rows may affect downstream logic that depends on string placeholders. Verify that downstream processing and validations handle np.nan values correctly.
df.loc[idx] = [np.nan] * df.shape[1]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now possible to fill the parameter values from the sbml model